CVE-2013-1966

aka OGNL URL Injection

CVE: CVE-2013-1966
CWE: CWE-94 Code Injection
bugs: []
vccs:
- note: Move XWork core under Struts 2
  commit: 0c543aef318341ca9bd482e15f1637497b8a4dfd
- note: 
  commit: 
fixes:
- note: Eliminates double evaluation
  commit: 7e6f641ebb142663cbd1653dc49bed725edf7f56
- note: 
  commit: 
bounty:
  amt: 
  url: 
  announced: 
lessons:
  yagni:
    note: The fix involved removing functionality that was added despite being deemed
      unnecessary and creating vulnerabilities.
    applies: true
  question: |
    Are there any common lessons we have learned from class that apply to this
    vulnerability? In other words, could this vulnerability serve as an example
    of one of those lessons?
    Leave "applies" blank or put false if you did not see that lesson (you do
    not need to put a reason). Put "true" if you feel the lesson applies and put
    a quick explanation of how it applies.
    Don't feel the need to claim that ALL of these apply, but it's pretty likely
    that one or two of them apply.
    If you think of another lesson we covered in class that applies here, feel
    free to give it a small name and add one in the same format as these.
  serial_killer:
    note: 
    applies: 
  complex_inputs:
    note: 
    applies: 
  distrust_input:
    note: Input put in by malicious agents was the main worry in this vulnerability,
      and sanitizing input helped fix those errors.
    applies: true
  least_privilege:
    note: 
    applies: 
  native_wrappers:
    note: 
    applies: 
  defense_in_depth:
    note: 
    applies: 
  secure_by_default:
    note: 
    applies: 
  environment_variables:
    note: 
    applies: 
  security_by_obscurity:
    note: 
    applies: 
  frameworks_are_optional:
    note: 
    applies: 
upvotes: 
mistakes:
  answer: There were two major mistakes that likely led to this vulnerability being
    created.  First was importing the XWork files without fully considering what vulnerabilities
    they may create.  Second, the input through URL parameters, which are very easily
    modifiable, were not being properly sanitized, which allowed code to be executed
    very easily, which is a major problem in software systems.
  question: |
    In your opinion, after all of this research, what mistakes were made that
    led to this vulnerability? Coding mistakes? Design mistakes?
    Maintainability? Requirements? Miscommunications?
    Look at the CWE entry for this vulnerability and examine the mitigations
    they have written there. Are they doing those? Does the fix look proper?
    Use those questions to inspire your answer. Don't feel obligated to answer
    every one. Write a thoughtful entry here that those in the software
    engineering industry would find interesting.
nickname: OGNL URL Injection
reported: '2013-04-18'
announced: '2013-05-23'
subsystem:
  name: xwork2
  answer: This was in the config files for the xwork packages included in Struts.
  question: |
    What subsystems was the mistake in?
    Look at the path of the source code files code that were fixed to get
    directory names. Look at comments in the code. Look at the bug reports how
    the bug report was tagged. Examples: "clipboard", "gpu", "ssl", "speech", "renderer"
discovered:
  date: '2013-04-18'
  answer: This bug was discovered by the Struts team, specifically reported by Vincent
    Danen, and it was patched for a later release.
  apache: true
  contest: false
  question: |
    How was this vulnerability discovered?
    Go to the bug report and read the conversation to find out how this was
    originally found. Answer in longform below in "answer", fill in the date in
    YYYY-MM-DD, and then determine if the vulnerability was found by a Apache
    employee (you can tell from their email address). If it's clear that the
    vulnerability was discovered by a contest, fill in the name there.
    The "automated" flag can be true, false, or nil.
    The "apache" flag can be true, false, or nil.
    If there is no evidence as to how this vulnerability was found, then you may
    leave the entries blank except for "answer". Write down where you looked in "answer".
  automated: 
description: "URL requests containing parameters were not properly handled and sanitized.
  \ \nThis allowed malicious code in the Apache Object Graph Navigation Language (OGNL)
  to be executed by typing commands in the URL parameters.\n"
unit_tested:
  fix: false
  code: true
  answer: The unit tests were not changed, but unit tests do exist throughout the
    application for this functionality, as they are not necessary due to disabling
    vulnerable functionality.
  question: |
    Were automated unit tests involved in this vulnerability?
    Was the original code unit tested, or not unit tested? Did the fix involve
    improving the automated tests?
    Write the reasoning behind your answer in the "answer" field.
    For the "code" answer below, look not only at the fix but the surrounding
    code near the fix and determine if and was there were unit tests involved
    for this module. Must be just "true" or "false".
    For the "fix" answer below, check if the fix for the vulnerability involves
    adding or improving an automated test to ensure this doesn't happen again.
    Must be just "true" or "false".
future_fixes:
- note: 
  commit: 
curation_level: 1
previous_fixes:
- note: 
  commit: 
- note: 
  commit: 
CWE_instructions: |
  Please go to cwe.mitre.org and find the most specific, appropriate CWE entry
  that describes your vulnerability. (Tip: this may not be a good one to start
  with - spend time understanding this vulnerability before making your choice!)
security_bulletin: S2-013
bounty_instructions: |
  If you came across any indications that a bounty was paid out for this
  vulnerability, fill it out here. Or correct it if the information already here
  was wrong. Otherwise, leave it blank.
interesting_commits:
  answer: There were several years and thousands of commits between the VCC and fix,
    so that alone is interesting because the vulnerability went undiscovered for years,
    and was likely exploited many times before it was finally discovered and fixed
    by the team, showing that the team should have been performing more thorough testing
    to search for potential vulnerabilities.
  commits:
  - note: 
    commit: 
  - note: 
    commit: 
  question: |
    Are there any interesting commits between your VCC(s) and fix(es)?
    Write a brief (under 100 words) description of why you think this commit was
    interesting in light of the lessons learned from this vulnerability. Any
    emerging themes?
    If there are no interesting commits, demonstrate that you completed this section
    by explaining what happened between the VCCs and the fix.
curated_instructions: |
  If you are manually editing this file, then you are "curating" it. Set the
  entry below to "true" as soon as you start. This will enable additional
  integrity checks on this file to make sure you fill everything out properly.
  If you are a student, we cannot accept your work as finished unless curated is
  set to true.
upvotes_instructions: |
  Students: when initially writing this, ignore this upvotes number.
  Once this work is being reviewed, you will be giving a certain amount of
  upvotes to each vulnerability you see. Your peers will tell you how
  interesting they think this vulnerability is, and you'll add that to the
  upvotes score on your branch.
nickname_instructions: |
  Nickname is optional. Provide a useful, professional, and catchy nickname for
  this vulnerability. Ideally fewer than 30 characters. This will be shown
  alongside its CVE to make it more easily distinguished from the rest.
reported_instructions: |
  Was there a date that this vulnerability was reported to the team? You can
  find this in changelogs, blogs, bug reports, or perhaps the CVE data.
  Please enter your date in YYYY-MM-DD format.
announced_instructions: |
  Was there a date that this vulnerability was announced to the world? You can
  find this in changelogs, blogs, bug reports, or perhaps the CVE data.
  Please enter your date in YYYY-MM-DD format.
fixes_vcc_instructions: |
  Please put the SVN commit number in "commit" below, and any notes about how this
  was discovered in the "note" field.
description_instructions: |
  You can get an initial description from the CVE entry on cve.mitre.org. These
  descriptions are a fine start, but they can be kind of jargony.
  Rewrite this description in your own words. Make it interesting and easy to
  read to anyone with some programming experience. We can always pull up the NVD
  description later to get more technical.
  Try to still be specific in your description, but remove Struts-specific
  stuff. Remove references to versions, specific filenames, and other jargon
  that outsiders to Struts would not understand. Technology like "regular
  expressions" is fine, and security phrases like "invalid write" are fine to
  keep too.
incomplete_fix_instructions: |
  Did the above "fixes" actually fix the vulnerability?
  Please list any fixes for the same issue before and after
  this CVE below.