CVE-2014-0117

CVE: CVE-2014-0117
CWE: 150
ipc:
  note: 
  answer: 
  question: |
    Did the feature that this vulnerability affected use inter-process
    communication? IPC includes OS signals, pipes, stdin/stdout, message
    passing, and clipboard. Writing to files that another program in this
    software system reads is another form of IPC.

    Answer should be boolean. Explain your answer
bugs: []
i18n:
  note: 
  answer: 
  instructions: |
    Was the feature impacted by this vulnerability about internationalization
    (i18n)? An internationalization feature is one that enables people from all
    over the world to use the system. This includes translations, locales,
    typography, unicode, or various other features.

    Answer should be boolean. Write a note about how you came to the conclusions
    you did.
repo: 
vccs:
- note: "By Graham Leggett on 2013-05-13 20:11:36 +0000    \nIn the change it even
    says \"Make sure we skip empty tokens when parsing the Connection header.\"\nBut
    in the way they went about implementing this lead and easy work around with the
    semi-colon.\n"
  commit: d2e6782ea7a74046a0e30aa2b9b0f85e86396fff
fixes:
- note: |-
    Note that 6fdc17af7e9425c7e7e2b31cc5cf64e961b8c72e is a rollup including this change.

    This made sure to include semi-colons along with commas as delineators, not just commas.


    Formerly 0ad9ec32504e63c6017600c7de7ec4b4561b897d before HTTPD rewrote Git history.
  commit: bb4cc03e7541c9c4fef3055597d3160a11c45ecd
- note: Direct reference to the CVE. Official fix
  commit: bb2749fd6e18dd1682bd1da89b160ca4175c2ec1
bounty:
  amt: 
  url: 
  announced: 
lessons:
  yagni:
    note: 
    applies: 
  question: |
    Are there any common lessons we have learned from class that apply to this
    vulnerability? In other words, could this vulnerability serve as an example
    of one of those lessons?

    Leave "applies" blank or put false if you did not see that lesson (you do
    not need to put a reason). Put "true" if you feel the lesson applies and put
    a quick explanation of how it applies.

    Don't feel the need to claim that ALL of these apply, but it's pretty likely
    that one or two of them apply.

    If you think of another lesson we covered in class that applies here, feel
    free to give it a small name and add one in the same format as these.
  serial_killer:
    note: 
    applies: 
  complex_inputs:
    note: 
    applies: 
  distrust_input:
    note: |
      The input between the header parser and the proxy module had an implied
      trust between them that should not have been there.
    applies: true
  least_privilege:
    note: 
    applies: 
  native_wrappers:
    note: 
    applies: 
  defense_in_depth:
    note: 
    applies: 
  secure_by_default:
    note: 
    applies: 
  environment_variables:
    note: 
    applies: 
  security_by_obscurity:
    note: 
    applies: 
  frameworks_are_optional:
    note: 
    applies: 
reviews: []
upvotes: 
CWE_note: 
mistakes:
  answer: |
    I think there was a simple error of not thorough enough tests. Having an empty
    Connection Header does not seem like an over-complicated input to test. I understand
    it was a more niche situation as it was while use of the proxy module, but proxy servers themselves are not
    niche at all. I think they just need to extend their unit tests to test data passing between modules as well.
  question: |
    In your opinion, after all of this research, what mistakes were made that
    led to this vulnerability? Coding mistakes? Design mistakes?
    Maintainability? Requirements? Miscommunications?

    Look at the CWE entry for this vulnerability and examine the mitigations
    they have written there. Are they doing those? Does the fix look proper?

    Use those questions to inspire your answer. Don't feel obligated to answer
    every one. Write a thoughtful entry here that those ing the software
    engineering industry would find interesting.
nickname: 
reported: 
announced: '2014-07-20'
published: 
subsystem:
  name: 
  answer: |
    modules/proxy/proxy_util.c
    server/util.c
    modules/proxy/mod_proxy_http.c
  question: |
    What subsystems was the mistake in?

    Look at the path of the source code files code that were fixed to get
    directory names. Look at comments in the code. Look at the bug reports how
    the bug report was tagged.
discovered:
  date: '2014-04-07'
  answer: "The vulnerability was found on the 7th of April 2014 by Mark Kroemeke,
    AKAT-1 and \n22733db72ab3ed94b5f8a1ffcde850251fe6f466\n"
  google: false
  contest: 
  question: |
    How was this vulnerability discovered?

    Go to the bug report and read the conversation to find out how this was
    originally found. Answer in longform below in "answer", fill in the date in
    YYYY-MM-DD, and then determine if the vulnerability was found by a Google
    employee (you can tell from their email address). If it's clear that the
    vulenrability was discovered by a contest, fill in the name there.

    The "automated" flag can be true, false, or nil.
    The "google" flag can be true, false, or nil.

    If there is no evidence as to how this vulnerability was found, then you may
    leave this part blank.
  automated: false
description: "The HTTP Connection headers is left blank like 'Connection ;' so that
  the parser\nwill get an empty string and then it will skip over the semi colon and
  place it as the value of\nthe variable connection. This makes it so when the code
  for the proxy token is used it uses logic \nbased on whitespaces and deliniated
  by commas and semi-colons. This is a vulnerability because\nthey use an inherent
  assumption that the input being passed is already sanitized and compatible.\n"
unit_tested:
  fix: false
  code: false
  answer: "Automated unit tests were most likely used on the code where the vulnerability\nlies
    but not all the unit tests are not publicized on their repos, for good reason.\nThe
    fix, and even looking at the squashed commit that included the fix commit, there
    \nis no change to the available unit test that we can see from the repos.\n"
  question: |
    Were automated unit tests involved in this vulnerability?
    Was the original code unit tested, or not unit tested? Did the fix involve
    improving the automated tests?

    For the "code" answer below, look not only at the fix but the surrounding
    code near the fix and determine if and was there were unit tests involved
    for this module.

    For the "fix" answer below, check if the fix for the vulnerability involves
    adding or improving an automated test to ensure this doesn't happen again.
specification:
  answer: 
  answer_note: 
  instructions: |
    Is there mention of a violation of a specification? For example,
    an RFC specification, a protocol specification, or a requirements
    specification.

    Be sure to check all artifacts for this: bug report, security
    advisory, commit message, etc.

    The answer field should be boolean. In answer_note, please explain
    why you come to that conclusion.
curation_level: 1
CWE_instructions: |
  Please go to cwe.mitre.org and find the most specific, appropriate CWE entry
  that describes your vulnerability. (Tip: this may not be a good one to start
  with - spend time understanding this vulnerability before making your choice!)
autodiscoverable:
  answer: 
  answer_note: 
  instructions: |
    Is it plausible that a fully automated tool could have discovered
    this? These are tools that require little knowledge of the domain,
     e.g. automatic static analysis, compiler warnings, fuzzers.

    Examples for true answers: SQL injection, XSS, buffer overflow

    Examples for false: RFC violations, permissions issues, anything
    that requires the tool to be "aware" of the project's
    domain-specific requirements.

    The answer field should be boolean. In answer_note, please explain
    why you come to that conclusion.
yaml_instructions: 
bounty_instructions: |
  If you came across any indications that a bounty was paid out for this
  vulnerability, fill it out here. Or correct it if the information already here
  was wrong. Otherwise, leave it blank.
interesting_commits:
  commits:
  - note: 'This is the only commit that touched this file for a couple years but it
      didn''t change the vulnerability functionality in any way.

      '
    commit: 817b1ea2c0df455620ce3d31e0d55ffa94c134db
  - note: 
    commit: 
  question: |
    Are there any interesting commits between your VCC(s) and fix(es)?

    Write a brief (under 100 words) description of why you think this commit was
    interesting in light of the lessons learned from this vulnerability. Any
    emerging themes?
curated_instructions: |
  If you are manually editing this file, then you are "curating" it. Set the
  entry below to "true" as soon as you start. This will enable additional
  integrity checks on this file to make sure you fill everything out properly.
  If you are a student, we cannot accept your work as finished unless curated is
  set to true.
upvotes_instructions: |
  For the first round, ignore this upvotes number.

  For the second round of reviewing, you will be giving a certain amount of
  upvotes to each vulnerability you see. Your peers will tell you how
  interesting they think this vulnerability is, and you'll add that to the
  upvotes score on your branch.
nickname_instructions: |
  A catchy name for this vulnerability that would draw attention it. If the
  report mentions a nickname, use that. Must be under 30 characters.
  Optional.
reported_instructions: |
  What date was the vulnerability reported to the security team? Look at the
  security bulletins and bug reports. It is not necessarily the same day that the
  CVE was created.  Leave blank if no date is given.
  Please enter your date in YYYY-MM-DD format.
announced_instructions: |
  Was there a date that this vulnerability was announced to the world? You can
  find this in changelogs, blogs, bug reports, or perhaps the CVE date. A good
  source for this is Chrome's Stable Release Channel
  (https://chromereleases.googleblog.com/).
  Please enter your date in YYYY-MM-DD format.
fixes_vcc_instructions: |
  Please put the commit hash in "commit" below (see my example in
  CVE-2011-3092.yml). Fixes and VCCs follow the same format.
published_instructions: |
  Is there a published fix or patch date for this vulnerability?
  Please enter your date in YYYY-MM-DD format.
description_instructions: |
  You can get an initial description from the CVE entry on cve.mitre.org. These
  descriptions are a fine start, but they can be kind of jargony.

  Rewrite this description in your own words. Make it interesting and easy to
  read to anyone with some programming experience. We can always pull up the NVD
  description later to get more technical.

  Try to still be specific in your description, but remove Chromium-specific
  stuff. Remove references to versions, specific filenames, and other jargon
  that outsiders to Chromium would not understand. Technology like "regular
  expressions" is fine, and security phrases like "invalid write" are fine to
  keep too.