CVE-2014-7923

CVE: CVE-2014-7923
CWE:
- 119
- 17
bugs:
- 430353
repo: https://chromium.googlesource.com/v8/v8/
vccs:
- note: 
  commit: 0f97763f80b69d6bb3fb974c63024de93e518c74
fixes:
- note: Fix in the Chromium project but the change involves updating the version of
    ICU (International Component for Unicode) from `d8b2a9d` to `6242e2f`.
  commit: 2e9716bacd10f8e8444190894fec0e4d55804a7e
- note: Fix in the upstream ICU project traced using `ICU-11370`---identifier of the
    bug associated with the vulnerability from the ICU bug tracking system (https://unicode-org.atlassian.net/browse/ICU-11370)---in
    the commit message.
  commit: 9db433b745aaffe76930c7d583a3f240f9ab5c75
bounty:
  date: '2015-01-21'
  amount: 5000.0
  references:
  - http://chromereleases.googleblog.com/2015/01/stable-update.html
lessons:
  yagni:
    note: 
    applies: false
  question: |
    Are there any common lessons we have learned from class that apply to this
    vulnerability? In other words, could this vulnerability serve as an example
    of one of those lessons?

    Leave "applies" blank or put false if you did not see that lesson (you do
    not need to put a reason). Put "true" if you feel the lesson applies and put
    a quick explanation of how it applies.

    Don't feel the need to claim that ALL of these apply, but it's pretty likely
    that one or two of them apply.

    If you think of another lesson we covered in class that applies here, feel
    free to give it a small name and add one in the same format as these.
  serial_killer:
    note: 
    applies: false
  complex_inputs:
    note: 
    applies: false
  distrust_input:
    note: An alternative to fixing enviroinmental variables would be an additional
      check on the input.
    applies: true
  least_privilege:
    note: 
    applies: false
  native_wrappers:
    note: 
    applies: false
  defense_in_depth:
    note: 
    applies: false
  secure_by_default:
    note: 
    applies: false
  environment_variables:
    note: The setup for this project seemed to be the major source of this vulnerability.
    applies: true
  security_by_obscurity:
    note: 
    applies: false
  frameworks_are_optional:
    note: 
    applies: false
reviews:
- 728883004
- 726973003
upvotes: 4
mistakes:
  answer: "This vulnerability seems to be an issue of maintainability. The configuration
    file \nwas not updated as needed and other issues were able to be exploited from
    the ICU regexp engine used.\n"
  question: |
    In your opinion, after all of this research, what mistakes were made that
    led to this vulnerability? Coding mistakes? Design mistakes?
    Maintainability? Requirements? Miscommunications?

    Look at the CWE entry for this vulnerability and examine the mitigations
    they have written there. Are they doing those? Does the fix look proper?

    Use those questions to inspire your answer. Don't feel obligated to answer
    every one. Write a thoughtful entry here that those ing the software
    engineering industry would find interesting.
announced: '2015-01-22'
subsystem:
  name: blink
  answer: DEPS configuration file.
  question: |
    What subsystems was the mistake in?

    Look at the path of the source code files code that were fixed to get
    directory names. Look at comments in the code. Look at the bug reports how
    the bug report was tagged. Examples: "clipboard", "gpu", "ssl", "speech", "renderer"
discovered:
  date: '2014-11-05'
  answer: This vulnerability was reported by an "external researcher" referred to
    as "yangdingning" for a reward of $5,000.
  google: false
  contest: false
  question: |
    How was this vulnerability discovered?

    Go to the bug report and read the conversation to find out how this was
    originally found. Answer in longform below in "answer", fill in the date in
    YYYY-MM-DD, and then determine if the vulnerability was found by a Google
    employee (you can tell from their email address). If it's clear that the
    vulenrability was discovered by a contest, fill in the name there.

    The "automated" flag can be true, false, or nil.
    The "google" flag can be true, false, or nil.

    If there is no evidence as to how this vulnerability was found, then you may
    leave the entries blank except for "answer". Write down where you looked in "answer".
  automated: false
description: "For the Regular Expressions package used within Chromium (International
  Components for Unicode),\nopcodes are represented by a 32-bit Integer. The first
  8 bits represent the type of opcode.\nThe remaining 24 bits represent optional parameters.
  \n\nOne parameter of the URX_LBN_CONT opcode requires the max length of a lookbehind
  regex match.\nWhen this pattern is eventually assigned to a variable, it's range
  was not checked. Therefore,\nif it's value was large enough, it could overflow the
  parameter bits and change the opcode\ntype.\n\nThis would potentially allow an attacker
  to execute machine code.\n"
unit_tested:
  fix: false
  code: true
  answer: |
    The VCC (re) implemented many unit tests, however this fix did not involve
    changing those.
  question: |
    Were automated unit tests involved in this vulnerability?
    Was the original code unit tested, or not unit tested? Did the fix involve
    improving the automated tests?

    For the "code" answer below, look not only at the fix but the surrounding
    code near the fix and determine if and was there were unit tests involved
    for this module.

    For the "fix" answer below, check if the fix for the vulnerability involves
    adding or improving an automated test to ensure this doesn't happen again.
major_events:
  answer: n/a.
  events:
  - date: 
    name: 
  - date: 
    name: 
  question: |
    Please record any major events you found in the history of this
    vulnerability. Was the code rewritten at some point? Was a nearby subsystem
    changed? Did the team change?

    The event doesn't need to be directly related to this vulnerability, rather,
    we want to capture what the development team was dealing with at the time.
curation_level: 1
CWE_instructions: |
  Please go to cwe.mitre.org and find the most specific, appropriate CWE entry
  that describes your vulnerability. (Tip: this may not be a good one to start
  with - spend time understanding this vulnerability before making your choice!)
bounty_instructions: |
  If you came across any indications that a bounty was paid out for this
  vulnerability, fill it out here. Or correct it if the information already here
  was wrong. Otherwise, leave it blank.
interesting_commits:
  answer: Implementing some browser tests that require changing the same third party
    option ins for the ICU 52 regex.
  commits:
  - note: Made all the single byte encodings compliant to the encoding spec.
    commit: 0f97763f80b69d6bb3fb974c63024de93e518c74
  question: |
    Are there any interesting commits between your VCC(s) and fix(es)?

    Write a brief (under 100 words) description of why you think this commit was
    interesting in light of the lessons learned from this vulnerability. Any
    emerging themes?

    If there are no interesting commits, demonstrate that you completed this section by
    explaining what happened between the VCCs and the fix.
curated_instructions: |
  If you are manually editing this file, then you are "curating" it. Set the
  entry below to "true" as soon as you start. This will enable additional
  integrity checks on this file to make sure you fill everything out properly.
  If you are a student, we cannot accept your work as finished unless curated is
  set to true.
upvotes_instructions: |
  For the first round, ignore this upvotes number.

  For the second round of reviewing, you will be giving a certain amount of
  upvotes to each vulnerability you see. Your peers will tell you how
  interesting they think this vulnerability is, and you'll add that to the
  upvotes score on your branch.
announced_instructions: |
  Was there a date that this vulnerability was announced to the world? You can
  find this in changelogs, blogs, bug reports, or perhaps the CVE date. A good
  source for this is Chrome's Stable Release Channel
  (https://chromereleases.googleblog.com/).
  Please enter your date in YYYY-MM-DD format.
fixes_vcc_instructions: |
  Please put the commit hash in "commit" below (see my example in
  CVE-2011-3092.yml). Fixes and VCCs follow the same format.
description_instructions: |
  You can get an initial description from the CVE entry on cve.mitre.org. These
  descriptions are a fine start, but they can be kind of jargony.

  Rewrite this description in your own words. Make it interesting and easy to
  read to anyone with some programming experience. We can always pull up the NVD
  description later to get more technical.

  Try to still be specific in your description, but remove Chromium-specific
  stuff. Remove references to versions, specific filenames, and other jargon
  that outsiders to Chromium would not understand. Technology like "regular
  expressions" is fine, and security phrases like "invalid write" are fine to
  keep too.