CVE-2014-7941

CVE: CVE-2014-7941
CWE:
- 119
bugs:
- 428557
repo: https://chromium.googlesource.com/chromium
vccs:
- note: Enable copying long text to Chrome and pasting long text from Chrome
  commit: 7e794388d8890d756c5d3f26c5fadb8004492fc7
fixes:
- note: Altered the program to pass in values of a long type to XChangeProperty()
    instead of an int type when using format=32.  The correction was also made in
    the method to accept values of type long.
  commit: f09a3116b3c3bff8d4c98dd65d659471a7eeff6f
bounty:
  date: '2015-01-21'
  amount: 2000.0
  references:
  - http://chromereleases.googleblog.com/2015/01/stable-update.html
lessons:
  yagni:
    note: 
    applies: false
  question: |
    Are there any common lessons we have learned from class that apply to this
    vulnerability? In other words, could this vulnerability serve as an example
    of one of those lessons?

    Leave "applies" blank or put false if you did not see that lesson (you do
    not need to put a reason). Put "true" if you feel the lesson applies and put
    a quick explanation of how it applies.

    Don't feel the need to claim that ALL of these apply, but it's pretty likely
    that one or two of them apply.

    If you think of another lesson we covered in class that applies here, feel
    free to give it a small name and add one in the same format as these.
  serial_killer:
    note: 
    applies: false
  complex_inputs:
    note: 
    applies: false
  distrust_input:
    note: 
    applies: false
  least_privilege:
    note: 
    applies: false
  native_wrappers:
    note: 
    applies: false
  defense_in_depth:
    note: 
    applies: false
  integer_overflow:
    note: This bug was directly caused by overflowing the data structure and was resolved
      by switching to a long
    applies: true
  secure_by_default:
    note: 
    applies: false
  environment_variables:
    note: 
    applies: false
  security_by_obscurity:
    note: 
    applies: false
  frameworks_are_optional:
    note: 
    applies: false
reviews:
- 697863002
upvotes: 1
mistakes:
  answer: |
    This vulnerability was caused by a coding mistake. The developers did
    not fully think through what data would be stored in this variable.
    From this bug, you can see how useful fuzzers can be. Two different
    fuzzers were able to find this bug, which shows that it is not
    super difficult to make a useful fuzzer.
  question: |
    In your opinion, after all of this research, what mistakes were made that
    led to this vulnerability? Coding mistakes? Design mistakes?
    Maintainability? Requirements? Miscommunications?

    Look at the CWE entry for this vulnerability and examine the mitigations
    they have written there. Are they doing those? Does the fix look proper?

    Use those questions to inspire your answer. Don't feel obligated to answer
    every one. Write a thoughtful entry here that those ing the software
    engineering industry would find interesting.
announced: '2015-01-22 17:59:21.727000000 -05:00'
subsystem:
  name: UI
  answer: Based on the path of the changed file
  question: |
    What subsystems was the mistake in?

    Look at the path of the source code files code that were fixed to get
    directory names. Look at comments in the code. Look at the bug reports how
    the bug report was tagged. Examples: "clipboard", "gpu", "ssl", "speech", "renderer"
discovered:
  date: '2014-10-30'
  answer: This bug was found by two separate fuzzers around the same time
  google: false
  contest: false
  question: |
    How was this vulnerability discovered?

    Go to the bug report and read the conversation to find out how this was
    originally found. Answer in longform below in "answer", fill in the date in
    YYYY-MM-DD, and then determine if the vulnerability was found by a Google
    employee (you can tell from their email address). If it's clear that the
    vulenrability was discovered by a contest, fill in the name there.

    The "automated" flag can be true, false, or nil.
    The "google" flag can be true, false, or nil.

    If there is no evidence as to how this vulnerability was found, then you may
    leave the entries blank except for "answer". Write down where you looked in "answer".
  automated: true
description: One of the functions in the applications uses an int data type for a
  certain value that can get particularly large.  Since int variables have a smaller
  maximum value the variable was going over the max and looping back to the negative
  values.  Having negative values could cause a denial of service.
unit_tested:
  fix: false
  code: false
  answer: Automated unit tests were not involved.
  question: |
    Were automated unit tests involved in this vulnerability?
    Was the original code unit tested, or not unit tested? Did the fix involve
    improving the automated tests?

    For the "code" answer below, look not only at the fix but the surrounding
    code near the fix and determine if and was there were unit tests involved
    for this module.

    For the "fix" answer below, check if the fix for the vulnerability involves
    adding or improving an automated test to ensure this doesn't happen again.
major_events:
  answer: Yes, during the history of this bug Google updated the version of their
    trunk and fixed a large bug.
  events:
  - date: '2014-11-02'
    name: Updated trunk version from 2208 to 2209
  - date: '2014-11-01'
    name: Fixed a bug where getStats was blocking the UI thread for excessive amouts
      of time.  This change altered 22 individual files.
  question: |
    Please record any major events you found in the history of this
    vulnerability. Was the code rewritten at some point? Was a nearby subsystem
    changed? Did the team change?

    The event doesn't need to be directly related to this vulnerability, rather,
    we want to capture what the development team was dealing with at the time.
curation_level: 1
CWE_instructions: |
  Please go to cwe.mitre.org and find the most specific, appropriate CWE entry
  that describes your vulnerability. (Tip: this may not be a good one to start
  with - spend time understanding this vulnerability before making your choice!)
bounty_instructions: |
  If you came across any indications that a bounty was paid out for this
  vulnerability, fill it out here. Or correct it if the information already here
  was wrong. Otherwise, leave it blank.
interesting_commits:
  answer: 
  commits:
  - note: This commit was interesting because it involved a brief argument on who
      has access to approve a change to the repository.  The person who committed
      the code sent it to the wrong reviewers who were unable to merge the change
      into the repo.
    commit: 6d8de1a2a4a18e9629681be494434924cb9d46ad
  - note: This commit was interesting because Google decided to change their process
      for RTCPeerConnectionHandler to WeakPtr because the raw pointers that were being
      use on them before could lead to use-after-free.
    commit: 2c0f13b39d6ff1a867385e1acb7e6793a0440519
  question: |
    Are there any interesting commits between your VCC(s) and fix(es)?

    Write a brief (under 100 words) description of why you think this commit was
    interesting in light of the lessons learned from this vulnerability. Any
    emerging themes?

    If there are no interesting commits, demonstrate that you completed this section by explaining what happened between the VCCs and the fix.
curated_instructions: |
  If you are manually editing this file, then you are "curating" it. Set the
  entry below to "true" as soon as you start. This will enable additional
  integrity checks on this file to make sure you fill everything out properly.
  If you are a student, we cannot accept your work as finished unless curated is
  set to true.
upvotes_instructions: |
  For the first round, ignore this upvotes number.

  For the second round of reviewing, you will be giving a certain amount of
  upvotes to each vulnerability you see. Your peers will tell you how
  interesting they think this vulnerability is, and you'll add that to the
  upvotes score on your branch.
announced_instructions: |
  Was there a date that this vulnerability was announced to the world? You can
  find this in changelogs, blogs, bug reports, or perhaps the CVE date. A good
  source for this is Chrome's Stable Release Channel
  (https://chromereleases.googleblog.com/).
  Please enter your date in YYYY-MM-DD format.
fixes_vcc_instructions: |
  Please put the commit hash in "commit" below (see my example in
  CVE-2011-3092.yml). Fixes and VCCs follow the same format.
description_instructions: |
  You can get an initial description from the CVE entry on cve.mitre.org. These
  descriptions are a fine start, but they can be kind of jargony.

  Rewrite this description in your own words. Make it interesting and easy to
  read to anyone with some programming experience. We can always pull up the NVD
  description later to get more technical.

  Try to still be specific in your description, but remove Chromium-specific
  stuff. Remove references to versions, specific filenames, and other jargon
  that outsiders to Chromium would not understand. Technology like "regular
  expressions" is fine, and security phrases like "invalid write" are fine to
  keep too.