CVE-2016-1690

CVE: CVE-2016-1690
CWE: CWE-404
bugs:
- 608100
repo: 
vccs:
- note: commit that added the line to cause the crash
  commit: 9feaf5c81397fd4d8bc8512ba9aa9cfe94b4c815
fixes:
- note: ''
  commit: 50bf9075cac0e5d69f5adfc0763968d5afa1734b
- note: ''
  commit: 9de81f45c73a8f9f215fc234a6adfe087b0eab74
- note: ''
  commit: d62bc3e6e2c3be6bbb01fa325e3389f089974017
- note: ''
  commit: a8755e432460c9412291c0ae4dd887babb3fa506
bounty:
  date: '2016-05-25 15:45:00.000000000 -04:00'
  amount: 1000.0
  references:
  - http://chromereleases.googleblog.com/2016/05/stable-channel-update_25.html
lessons:
  yagni:
    note: 
    applies: 
  question: |
    Are there any common lessons we have learned from class that apply to this
    vulnerability? In other words, could this vulnerability serve as an example
    of one of those lessons?

    Leave "applies" blank or put false if you did not see that lesson (you do
    not need to put a reason). Put "true" if you feel the lesson applies and put
    a quick explanation of how it applies.

    Don't feel the need to claim that ALL of these apply, but it's pretty likely
    that one or two of them apply.

    If you think of another lesson we covered in class that applies here, feel
    free to give it a small name and add one in the same format as these.
  serial_killer:
    note: 
    applies: 
  complex_inputs:
    note: 
    applies: 
  distrust_input:
    note: An input can run java script to delete a form if the input is not checked
    applies: true
  least_privilege:
    note: 
    applies: 
  native_wrappers:
    note: 
    applies: 
  defense_in_depth:
    note: the program could still run once they check that the form was deleted so
      don't trust that any input works as expected
    applies: true
  secure_by_default:
    note: 
    applies: 
  environment_variables:
    note: The variable ignore_text_changes_ for the autofill is pointing to memory
      that was delete.
    applies: true
  security_by_obscurity:
    note: 
    applies: 
  frameworks_are_optional:
    note: 
    applies: 
reviews:
- 1951813002
- 1945723003
- 1960023002
- 1946143002
- 1943873002
upvotes: 
mistakes:
  answer: The design mistake was made by not checking input and trusting that input
    can be trusted to do what it was meant to do. They also can add a unit test to
    help make sure that future changes don't cause a similar bug.
  question: |
    In your opinion, after all of this research, what mistakes were made that
    led to this vulnerability? Coding mistakes? Design mistakes?
    Maintainability? Requirements? Miscommunications?

    Look at the CWE entry for this vulnerability and examine the mitigations
    they have written there. Are they doing those? Does the fix look proper?

    Use those questions to inspire your answer. Don't feel obligated to answer
    every one. Write a thoughtful entry here that those ing the software
    engineering industry would find interesting.
announced: '2016-06-05 19:59:19.617000000 -04:00'
subsystem:
  name: AutoFill
  answer: The auto fill subsystem was trusting input and allowing a UAF after the
    form was deleted
  question: |
    What subsystems was the mistake in?

    Look at the path of the source code files code that were fixed to get
    directory names. Look at comments in the code. Look at the bug reports how
    the bug report was tagged. Examples: "clipboard", "gpu", "ssl", "speech", "renderer"
discovered:
  date: '2016-04-29'
  answer: The bug report for the cve was created by rob@robwu.nl
  google: false
  contest: false
  question: |
    How was this vulnerability discovered?

    Go to the bug report and read the conversation to find out how this was
    originally found. Answer in longform below in "answer", fill in the date in
    YYYY-MM-DD, and then determine if the vulnerability was found by a Google
    employee (you can tell from their email address). If it's clear that the
    vulenrability was discovered by a contest, fill in the name there.

    The "automated" flag can be true, false, or nil.
    The "google" flag can be true, false, or nil.

    If there is no evidence as to how this vulnerability was found, then you may
    leave the entries blank except for "answer". Write down where you looked in "answer".
  automated: false
description: A user could set an input value (any text box that will utilize the auto
  fill feature) that could cause the form being viewed to be deleted. This would then
  cause the data from the autofill to be deleted as well. After all this data has
  been deleted there could still be process running and trying to use the deleted
  data from the auto fill which results in a crash.
unit_tested:
  fix: false
  code: false
  answer: There is no unit test, just an example of a test case to cause it
  question: |
    Were automated unit tests involved in this vulnerability?
    Was the original code unit tested, or not unit tested? Did the fix involve
    improving the automated tests?

    For the "code" answer below, look not only at the fix but the surrounding
    code near the fix and determine if and was there were unit tests involved
    for this module.

    For the "fix" answer below, check if the fix for the vulnerability involves
    adding or improving an automated test to ensure this doesn't happen again.
major_events:
  answer: 
  events:
  - date: 
    name: 
  - date: 
    name: 
  question: |
    Please record any major events you found in the history of this
    vulnerability. Was the code rewritten at some point? Was a nearby subsystem
    changed? Did the team change?

    The event doesn't need to be directly related to this vulnerability, rather,
    we want to capture what the development team was dealing with at the time.
curation_level: 0
CWE_instructions: |
  Please go to cwe.mitre.org and find the most specific, appropriate CWE entry
  that describes your vulnerability. (Tip: this may not be a good one to start
  with - spend time understanding this vulnerability before making your choice!)
bounty_instructions: |
  If you came across any indications that a bounty was paid out for this
  vulnerability, fill it out here. Or correct it if the information already here
  was wrong. Otherwise, leave it blank.
interesting_commits:
  answer: There was one interesting commit, there was a commit to potentially fix
    the autofill crash. It was similar to the vcc fix where it checks to see if the
    element is not null. But the root of the problem occured in form_autofill_agent
    which was not touched by this commit. There were no signs that this fix was ran
    against a test to ensure it fixed the bug.
  commits:
  - note: this was an earlier bug fix that checks that the element wasn't null in
      some methods but didn't get rid of the root issue.
    commit: d80f2526c38b3575f78d1e3335b2423110438c37
  - note: 
    commit: 
  question: |
    Are there any interesting commits between your VCC(s) and fix(es)?

    Write a brief (under 100 words) description of why you think this commit was
    interesting in light of the lessons learned from this vulnerability. Any
    emerging themes?

    If there are no interesting commits, demonstrate that you completed this section by explaining what happened between the VCCs and the fix.
curated_instructions: |
  If you are manually editing this file, then you are "curating" it. Set the
  entry below to "true" as soon as you start. This will enable additional
  integrity checks on this file to make sure you fill everything out properly.
  If you are a student, we cannot accept your work as finished unless curated is
  set to true.
upvotes_instructions: |
  For the first round, ignore this upvotes number.

  For the second round of reviewing, you will be giving a certain amount of
  upvotes to each vulnerability you see. Your peers will tell you how
  interesting they think this vulnerability is, and you'll add that to the
  upvotes score on your branch.
announced_instructions: |
  Was there a date that this vulnerability was announced to the world? You can
  find this in changelogs, blogs, bug reports, or perhaps the CVE date. A good
  source for this is Chrome's Stable Release Channel
  (https://chromereleases.googleblog.com/).
  Please enter your date in YYYY-MM-DD format.
fixes_vcc_instructions: |
  Please put the commit hash in "commit" below (see my example in
  CVE-2011-3092.yml). Fixes and VCCs follow the same format.
description_instructions: |
  You can get an initial description from the CVE entry on cve.mitre.org. These
  descriptions are a fine start, but they can be kind of jargony.

  Rewrite this description in your own words. Make it interesting and easy to
  read to anyone with some programming experience. We can always pull up the NVD
  description later to get more technical.

  Try to still be specific in your description, but remove Chromium-specific
  stuff. Remove references to versions, specific filenames, and other jargon
  that outsiders to Chromium would not understand. Technology like "regular
  expressions" is fine, and security phrases like "invalid write" are fine to
  keep too.