CVE-2018-16864

CVE: CVE-2018-16864
CWE: 789
ipc:
  note: The exploit allows writing to memory that other processes use
  answer: true
  question: |
    Did the feature that this vulnerability affected use inter-process
    communication? IPC includes OS signals, pipes, stdin/stdout, message
    passing, and clipboard. Writing to files that another program in this
    software system reads is another form of IPC.

    Answer must be true or false.
    Write a note about how you came to the conclusions you did, regardless of
    what your answer was.
bugs:
- https://bugzilla.redhat.com/show_bug.cgi?id=CVE-2018-16864
i18n:
  note: |
    There is nothing in the vulnerability relating to internationalizations
    since the vulnerability is caused by the size of input, not content.
  answer: false
  question: |
    Was the feature impacted by this vulnerability about internationalization
    (i18n)?

    An internationalization feature is one that enables people from all
    over the world to use the system. This includes translations, locales,
    typography, unicode, or various other features.

    Answer should be true or false
    Write a note about how you came to the conclusions you did, regardless of
    what your answer was.
vccs:
- note: The addition of strappenda() at line 558 was identified to be the VCC.
  commit: ae018d9bc900d6355dea4af05119b49c67945184
fixes:
- note: https://github.com/systemd/systemd/commit/084eeb865ca63887098e0945fb4e93c852b91b0f
  commit: '084eeb865ca63887098e0945fb4e93c852b91b0f'
vouch:
  note: No upvotes or public discussion found surrounding the bugfix
  answer: false
  question: "Was there any part of the fix that involved one person vouching for \nanother's
    work?\n\nThis can include:\n  * signing off on a commit message\n  * mentioning
    a discussion with a colleague checking the work\n  * upvoting a solution on a
    pull request\n\nAnswer must be true or false.\nWrite a note about how you came
    to the conclusions you did, regardless of what your answer was.\n"
bounty:
  amt: 
  url: 
  announced: 
lessons:
  yagni:
    note: 
    applies: 
  question: |
    Are there any common lessons we have learned from class that apply to this
    vulnerability? In other words, could this vulnerability serve as an example
    of one of those lessons?

    Leave "applies" blank or put false if you did not see that lesson (you do
    not need to put a reason). Put "true" if you feel the lesson applies and put
    a quick explanation of how it applies.

    Don't feel the need to claim that ALL of these apply, but it's pretty likely
    that one or two of them apply.

    If you think of another lesson we covered in class that applies here, feel
    free to give it a small name and add one in the same format as these.
  serial_killer:
    note: 
    applies: 
  complex_inputs:
    note: |
      The size of the commandline input was certainly a complex factor that
      developers did not initially take into consideration. This just proves one
      of the many ways input can be complex.
    applies: true
  distrust_input:
    note: |
      The program trusted that commandline input would be of a reasonable size,
      not big enough to crash stack allocated memory.
    applies: true
  least_privilege:
    note: 
    applies: 
  native_wrappers:
    note: 
    applies: 
  defense_in_depth:
    note: 
    applies: 
  secure_by_default:
    note: 
    applies: 
  environment_variables:
    note: 
    applies: 
  security_by_obscurity:
    note: 
    applies: 
  frameworks_are_optional:
    note: 
    applies: 
reviews: []
sandbox:
  note: |
    By crashing systemd, an attacker could potentially confuse the memory
    allocation done in journald to write to memory they were not supposed to.
    This is known as a Stack Clash vulnerability, and is considered a sandboxing
    violation.
  answer: true
  question: "Did this vulnerability violate a sandboxing feature that the system\nprovides?
    \n\nA sandboxing feature is one that allows files, users, or other features \nlimited
    access. Vulnerabilities that violate sandboxes are usually based on \naccess control,
    checking privileges incorrectly, path traversal, and the \nlike.\n\nAnswer should
    be true or false\nWrite a note about how you came to the conclusions you did,
    regardless of\nwhat your answer was.\n"
upvotes: 7
CWE_note: 
mistakes:
  answer: |
    The vulnerability was mainly the result of a planning error from the
    developers. They did not forsee that commandline input being saved in stack
    memory instead of heap memory would lead to a potential exploit due to its
    excessive size. In general, heap memory is larger than stack memory so it
    can hold larger points of data.
  question: "In your opinion, after all of this research, what mistakes were made
    that\nled to this vulnerability? Coding mistakes? Design mistakes?\nMaintainability?
    Requirements? Miscommunications?\n\nThere can, and usually are, many mistakes
    behind a vulnerability.\n\nRemember that mistakes can come in many forms:\n* slip:
    failing to complete a properly planned step due to inattention\n          e.g.
    wrong key in the ignition\n          e.g. using < instead of <=\n* lapse: failing
    to complete a properly planned step due to memory failure\n          e.g. forgetting
    to put car in reverse before backing up\n          e.g. forgetting to check null\n*
    planning error: error that occurs when the plan is inadequate\n          e.g.
    getting stuck in traffic because you didn’t consider the \n               impact
    of the bridge closing\n          e.g. calling the wrong method\n          e.g.
    using a poor design\n\nThese are grey areas, of course. But do your best to analyze
    the mistakes \naccording to this framework.\n\nLook at the CWE entry for this
    vulnerability and examine the mitigations\nthey have written there. Are they doing
    those? Does the fix look proper?\n\nWrite a thoughtful entry here that people
    in the software engineering\nindustry would find interesting.\n"
nickname: 
subsystem:
  name: journald
  note: 'journald is a subsystem responsible for collecting and storing logging data

    '
  question: "What subsystems was the mistake in? These are subsystems WITHIN systemd\n\nTwo
    areas to look:\n  - Bug labels\n  - Directory names\n\nLook at the path of the
    source code files code that were fixed to get\ndirectory names. Look at comments
    in the code. Look at the bug reports how\nthe bug report was tagged. \n\nExample
    systemd subsystems are:\n  * fsck\n  * apparmor\n  * fstab\n  * sd-daemon\n\nName
    should be:\n  * all lowercase English letters\n  * NOT a specific file\n  * can
    have digits, and _-@/\n\nCan be multiple subsystems involved, in which case you
    can make it an array\ne.g.\n    name: [\"subsystemA\", \"subsystemB\"] # ok\n
    \   name: subsystemA # also ok\n"
discovered:
  answer: |
    A team of researchers from Qualys Research Labs did a third-party security
    advisory on systemd-journald and accidentally found the vulnerability while
    testing a different vulnerability (CVE-2018-14634). They reported their
    findings to Red Hat Product Security. A brief summary of their discovery and
    timeline can be found here:
    https://www.qualys.com/2019/01/09/system-down/system-down.txt
  contest: false
  question: |
    How was this vulnerability discovered?

    Go to the bug report and read the conversation to find out how this was
    originally found. Answer in longform below in "answer", fill in the date in
    YYYY-MM-DD, and then determine if the vulnerability was found by a Google
    employee (you can tell from their email address). If it's clear that the
    vulenrability was discovered by a contest, fill in the name there.

    The automated, contest, and developer flags can be true, false, or nil.

    If there is no evidence as to how this vulnerability was found, then please
    explain where you looked.
  automated: false
  developer: false
discussion:
  note: The vulnerability was fixed very quickly after being discovered
  question: "Was there any discussion surrounding this?\n\nA discussion can include
    debates, disputes, or polite talk about how to \nresolve uncertainty.\n\nExample
    include:\n  * Is this out of our scope?\n  * Is this a security?\n  * How should
    we fix this?\n\nJust because you see multiple comments doesn't mean it's a discussion.
    \nFor example:\n  * \"Fix line 10\". \"Ok\" is not what we call a discussion\n
    \ * \"Ping\" (reminding people)\n\nCheck the bugs reports, pull requests, and
    mailing lists archives.\n\nThese answers should be boolean.\n  discussed_as_security:
    true or false\n  any_discussion: true or false\n\nPut any links to disagreements
    you found in the notes section, or any other\ncomment you want to make.\n"
  any_discussion: false
  discussed_as_security: false
stacktrace:
  note: |
    There were no full stacktraces pointing to specific files, only an error
    message indicating a segfault in the journald service. The bugfixes were
    within the journald subsystem.
  question: "Are there any stacktraces in the bug reports? \n\nSecondly, if there
    is a stacktrace, is the fix in the same file that the \nstacktrace points to?
    \n\nIf there are no stacktraces, then both of these are false - but be sure to\nmention
    where you checked in the note.\n\nAnswer must be true or false.\nWrite a note
    about how you came to the conclusions you did, regardless of\nwhat your answer
    was.\n"
  any_stacktraces: false
  stacktrace_with_fix: false
description: |
  Early versions of systemd contained an exploit in systemd-journald - a service
  which collects and stores logging data, making use of the function syslog().
  Certain programs that made syslog() function calls could crash systemd if an
  extremely long number of command line arguments were given. This crash was
  caused by poor memory allocation.
unit_tested:
  fix: false
  code: false
  question: |
    Were automated unit tests involved in this vulnerability?
    Was the original code unit tested, or not unit tested? Did the fix involve
    improving the automated tests?

    For code: and fix: - your answer should be boolean.

    For the code_answer below, look not only at the fix but the surrounding
    code near the fix in related directories and determine if and was there were
    unit tests involved for this subsystem.

    For the fix_answer below, check if the fix for the vulnerability involves
    adding or improving an automated test to ensure this doesn't happen again.
  fix_answer: 
  code_answer: 
reported_date: '2018-11-26'
specification:
  note: No mention of spec violations found
  answer: false
  instructions: |
    Is there mention of a violation of a specification? For example, the POSIX
    spec, an RFC spec, a network protocol spec, or some other requirements
    specification.

    Be sure to check the following artifacts for this:
      * bug reports
      * security advisories
      * commit message
      * pull request
      * mailing lists
      * anything else

    The answer field should be boolean. In answer_note, please explain
    why you come to that conclusion.
announced_date: '2019-01-09'
curation_level: 1
published_date: '2019-01-11'
forgotten_check:
  note: |
    The fix mainly revolved around changing where commandline parameters were
    being stored: from stack memory to heap memory. The fix did not involve
    adding forgotten checks
  answer: false
  question: "Does the fix for the vulnerability involve adding a forgotten check?\n\nA
    \"forgotten check\" can mean many things. It often manifests as the fix \ninserting
    an entire if-statement or a conditional to an existing \nif-statement. Or a call
    to a method that checks something.\n\nExample of checks can include:\n  * null
    pointer checks\n  * check the current role, e.g. root\n  * boundary checks for
    a number\n  * consult file permissions\n  * check a return value\n\nAnswer must
    be true or false.\nWrite a note about how you came to the conclusions you did,
    regardless of\nwhat your answer was.\n"
CWE_instructions: |
  Please go to http://cwe.mitre.org and find the most specific, appropriate CWE
  entry that describes your vulnerability. We recommend going to
  https://cwe.mitre.org/data/definitions/699.html for the Software Development
  view of the vulnerabilities. We also recommend the tool
  http://www.cwevis.org/viz to help see how the classifications work.

  If you have anything to note about why you classified it this way, write
  something in CWE_note. This field is optional.

  Just the number here is fine. No need for name or CWE prefix. If more than one
  apply here, then place them in an array like this
    CWE: ["123", "456"] # this is ok
    CWE: [123, 456]     # also ok
    CWE: 123            # also ok
autodiscoverable:
  note: |
    The vulnerability was simply caused by a large input via command line
    argument. This is certainly an input that could be automatically tested via a
    fuzzer
  answer: true
  instructions: |
    Is it plausible that a fully automated tool could have discovered
    this? These are tools that require little knowledge of the domain,
     e.g. automatic static analysis, compiler warnings, fuzzers.

    Examples for true answers: SQL injection, XSS, buffer overflow

    In systemd, the actually use OZZ Fuzz. If there's a link to it, add it here.

    Examples for false: RFC violations, permissions issues, anything
    that requires the tool to be "aware" of the project's
    domain-specific requirements.

    The answer field should be boolean. In answer_note, please explain
    why you come to that conclusion.
vcc_instructions: "The vulnerability-contributing commits.\n\nThese are found by our
  tools by traversing the Git Blame history, where we \ndetermine which commit(s)
  introduced the functionality. \n\nLook up these VCC commits and verify that they
  are not simple refactorings, \nand that they are, in fact introducing the vulnerability
  into the system. \nOften, introducing the file or function is where the VCC is,
  but VCCs can be \nanything. \n\nPlace any notes you would like to make in the notes
  field.\n"
bugs_instructions: "What bugs and/or pull requests are involved in this vulnerability?
  \n\nFor systemd, this is typically their GitHub issues, but could also include \nbugs
  from other databases. Put a URL instead of a single number.\n"
yaml_instructions: |
  =================
  ===YAML Primer===
  =================
  This is a dictionary data structure, akin to JSON.
  Everything before a colon is a key, and the values here are usually strings
  For one-line strings, you can just use quotes after the colon
  For multi-line strings, as we do for our instructions, you put a | and then
  indent by two spaces

  For readability, we hard-wrap multi-line strings at 80 characters. This is
  not absolutely required, but appreciated.
fixes_instructions: "Please put the commit hash in \"commit\" below.\n\nThis must
  be a git commit hash from the systemd source repo, a  40-character \nhexademical
  string/\n\nPlace any notes you would like to make in the notes field.\n"
bounty_instructions: |
  If you came across any indications that a bounty was paid out for this
  vulnerability, fill it out here. Or correct it if the information already here
  was wrong. Otherwise, leave it blank.
interesting_commits:
  commits:
  - note: |
      While the vulnerability was introduced in 2013, this change made the
      vulnerability exploitable, according to the discoverers at Qualys.
    commit: ac2e41f5103ce2c679089c4f8fb6be61d7caec07
  question: |
    Are there any interesting commits between your VCC(s) and fix(es)?

    Use this to specify any commits you think are notable in some way, and
    explain why in the note.
order_of_operations:
  note: |
    The fix was about the operations themselves (where in memory to save certain
    data) and not the order of those operations.
  answer: false
  question: "Does the fix for the vulnerability involve correcting an order of \noperations?\n\nThis
    means the fix involves moving code around or changing the order of \nhow things
    are done. \n\nAnswer must be true or false.\nWrite a note about how you came to
    the conclusions you did, regardless of\nwhat your answer was.\n"
curated_instructions: "If you are manually editing this file, then you are \"curating\"
  it. \n\nSet the version number that you were given in the instructions. \n \nThis
  will enable additional editorial checks on this file to make sure you \nfill everything
  out properly. If you are a student, we cannot accept your work\nas finished unless
  curated is properly updated. \n"
upvotes_instructions: |
  For the first round, ignore this upvotes number.

  For the second round of reviewing, you will be giving a certain amount of
  upvotes to each vulnerability you see. Your peers will tell you how
  interesting they think this vulnerability is, and you'll add that to the
  upvotes score on your branch.
nickname_instructions: |
  A catchy name for this vulnerability that would draw attention it.
  If the report mentions a nickname, use that.
  Must be under 30 characters. Optional.
reported_instructions: |
  What date was the vulnerability reported to the security team? Look at the
  security bulletins and bug reports. It is not necessarily the same day that
  the CVE was created.  Leave blank if no date is given.

  Please enter your date in YYYY-MM-DD format.
announced_instructions: |
  Was there a date that this vulnerability was announced to the world? You can
  find this in changelogs, blogs, bug reports, or perhaps the CVE date.

  This is not the same as published date in the NVD - that is below.

  Please enter your date in YYYY-MM-DD format.
published_instructions: |
  Is there a published fix or patch date for this vulnerability?
  Please enter your date in YYYY-MM-DD format.
description_instructions: |
  You can get an initial description from the CVE entry on cve.mitre.org. These
  descriptions are a fine start, but they can be kind of jargony.

  Rewrite this description IN YOUR OWN WORDS. Make it interesting and easy to
  read to anyone with some programming experience. We can always pull up the NVD
  description later to get more technical.

  Try to still be specific in your description, but remove project-specific
  stuff. Remove references to versions, specific filenames, and other jargon
  that outsiders to this project would not understand. Technology like "regular
  expressions" is fine, and security phrases like "invalid write" are fine to
  keep too.

  Your target audience is people just like you before you took any course in
  security