1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 961 962 963 964 965 966 967 968 969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038 1039 1040 1041 1042 1043 1044 1045 1046 1047 1048 1049 1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064 1065 1066 1067 1068 1069 1070 1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082 1083 1084 1085 1086 1087 1088 1089 1090 1091 1092 1093 1094 1095 1096 1097 1098 1099 1100 1101 1102 1103 1104 1105 1106 1107 1108 1109 1110 1111 1112 1113 1114 1115 1116 1117 1118 1119 1120 1121 1122 1123 1124 1125 1126 1127 1128 1129 1130 1131 1132 1133 1134 1135 1136 1137 1138 1139 1140 1141 1142 1143 1144 1145 1146 1147 1148 1149 1150 1151 1152 1153 1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164 1165 1166 1167 1168 1169 1170 1171 1172 1173 1174 1175 1176 1177 1178 1179 1180 1181 1182 1183 1184 1185 1186 1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199 1200 1201 1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213 1214 1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228 1229 1230 1231 1232 1233 1234 1235 1236 1237 1238 1239 1240 1241 1242 1243 1244 1245 1246 1247 1248 1249 1250 1251 1252 1253 1254 1255 1256 1257 1258 1259 1260 1261 1262 1263 1264 1265 1266 1267 1268 1269 1270 1271 1272 1273 1274 1275 1276 1277 1278 1279 1280 1281 |
CVE: CVE-2020-12768 CWE: - '401' ipc: note: | The vulnerability does not sufficiently track and release allocated memory after it has been used. This issue does not impact IPC directly. answer: false question: | Did the feature that this vulnerability affected use inter-process communication? IPC includes OS signals, pipes, stdin/stdout, message passing, and clipboard. Writing to files that another program in this software system reads is another form of IPC. Answer must be true or false. Write a note about how you came to the conclusions you did, regardless of what your answer was. CVSS: CVSS:3.1/AV:L/AC:L/PR:L/UI:N/S:U/C:N/I:N/A:H bugs: - 1034995 - 1040855 - 1043347 - 1044120 - 1044767 - 1055014 - 1055117 - 1055186 - 1058115 - 1061843 - 1065600 - 1065729 - 1066382 - 1071995 - 1077428 - 1085030 - 1094244 - 1094840 - 1109695 - 1115431 - 1120163 - 1129923 - 1133021 - 1134760 - 1136666 - 1138374 - 1139944 - 1148868 - 1149032 - 1152148 - 1152457 - 1152472 - 1152489 - 1153274 - 1154353 - 1154488 - 1154492 - 1154824 - 1155518 - 1155798 - 1156315 - 1156395 - 1157169 - 1158050 - 1158242 - 1158265 - 1158748 - 1158765 - 1158775 - 1158983 - 1159058 - 1159781 - 1159867 - 1159886 - 1160388 - 1160634 - 1160947 - 1161099 - 1161495 - 1162002 - 1162063 - 1162209 - 1162400 - 1162702 - 1163592 - 1163727 - 1164648 - 1164777 - 1164780 - 1165211 - 1165455 - 1165629 - 1165692 - 1165933 - 1165975 - 1166146 - 1166166 - 1166340 - 1166965 - 1166985 - 1167030 - 1167104 - 1167527 - 1167651 - 1167657 - 1167773 - 1167851 - 1168230 - 1168461 - 1168468 - 1168779 - 1168838 - 1168952 - 1168959 - 1169021 - 1169094 - 1169194 - 1169263 - 1169514 - 1169681 - 1169763 - 1169771 - 1169790 - 1169795 - 1170011 - 1170139 - 1170232 - 1170284 - 1170415 - 1170442 - 1170617 - 1170621 - 1170774 - 1170879 - 1170891 - 1170895 - 1171000 - 1171068 - 1171073 - 1171078 - 1171117 - 1171150 - 1171156 - 1171189 - 1171191 - 1171218 - 1171219 - 1171220 - 1171236 - 1171242 - 1171246 - 1171285 - 1171293 - 1171374 - 1171390 - 1171391 - 1171392 - 1171417 - 1171426 - 1171507 - 1171513 - 1171514 - 1171529 - 1171530 - 1171558 - 1171634 - 1171644 - 1171662 - 1171675 - 1171688 - 1171699 - 1171709 - 1171730 - 1171732 - 1171736 - 1171739 - 1171742 - 1171743 - 1171759 - 1171773 - 1171774 - 1171775 - 1171776 - 1171777 - 1171778 - 1171779 - 1171780 - 1171781 - 1171782 - 1171783 - 1171784 - 1171785 - 1171786 - 1171787 - 1171788 - 1171789 - 1171790 - 1171791 - 1171792 - 1171793 - 1171794 - 1171795 - 1171796 - 1171797 - 1171798 - 1171799 - 1171810 - 1171827 - 1171828 - 1171832 - 1171833 - 1171834 - 1171835 - 1171839 - 1171840 - 1171841 - 1171842 - 1171843 - 1171844 - 1171849 - 1171857 - 1171868 - 1171904 - 1171915 - 1171982 - 1171983 - 1171988 - 1172017 - 1172046 - 1172061 - 1172062 - 1172063 - 1172064 - 1172065 - 1172066 - 1172067 - 1172068 - 1172069 - 1172073 - 1172086 - 1172095 - 1172108 - 1172145 - 1172169 - 1172170 - 1172197 - 1172201 - 1172208 - 1172223 - 1172247 - 1172317 - 1172342 - 1172343 - 1172344 - 1172365 - 1172366 - 1172374 - 1172391 - 1172393 - 1172394 - 1172418 - 1172419 - 1172453 - 1172458 - 1172467 - 1172484 - 1172537 - 1172543 - 1172687 - 1172719 - 1172733 - 1172739 - 1172751 - 1172757 - 1172759 - 1172775 - 1172781 - 1172782 - 1172783 - 1172814 - 1172823 - 1172841 - 1172871 - 1172873 - 1172938 - 1172939 - 1172940 - 1172956 - 1172963 - 1172983 - 1172984 - 1172985 - 1172986 - 1172987 - 1172988 - 1172989 - 1172990 - 1172999 - 1173017 - 1173068 - 1173074 - 1173085 - 1173115 - 1173139 - 1173206 - 1173267 - 1173271 - 1173280 - 1173284 - 1173428 - 1173438 - 1173461 - 1173468 - 1173485 - 1173514 - 1173552 - 1173573 - 1173625 - 1173746 - 1173776 - 1173798 - 1173813 - 1173817 - 1173818 - 1173820 - 1173822 - 1173823 - 1173824 - 1173825 - 1173826 - 1173827 - 1173828 - 1173830 - 1173831 - 1173832 - 1173833 - 1173834 - 1173836 - 1173837 - 1173838 - 1173839 - 1173841 - 1173843 - 1173844 - 1173845 - 1173847 - 1173849 - 1173860 - 1173894 - 1173941 - 1173954 - 1174002 - 1174003 - 1174018 - 1174026 - 1174029 - 1174072 - 1174098 - 1174110 - 1174111 - 1174116 - 1174126 - 1174127 - 1174128 - 1174129 - 1174146 - 1174185 - 1174205 - 1174244 - 1174263 - 1174264 - 1174331 - 1174332 - 1174333 - 1174345 - 1174356 - 1174358 - 1174362 - 1174387 - 1174396 - 1174398 - 1174407 - 1174409 - 1174411 - 1174438 - 1174462 - 1174484 - 1174486 - 1174513 - 1174527 - 1174625 - 1174627 - 1174645 - 1174689 - 1174699 - 1174737 - 1174748 - 1174757 - 1174762 - 1174770 - 1174771 - 1174777 - 1174805 - 1174824 - 1174825 - 1174852 - 1174865 - 1174880 - 1174897 - 1174899 - 1174906 - 1174969 - 1175009 - 1175010 - 1175011 - 1175012 - 1175013 - 1175014 - 1175015 - 1175016 - 1175017 - 1175018 - 1175019 - 1175020 - 1175021 - 1175052 - 1175079 - 1175112 - 1175116 - 1175128 - 1175149 - 1175175 - 1175176 - 1175180 - 1175181 - 1175182 - 1175183 - 1175184 - 1175185 - 1175186 - 1175187 - 1175188 - 1175189 - 1175190 - 1175191 - 1175192 - 1175195 - 1175199 - 1175213 - 1175232 - 1175263 - 1175284 - 1175296 - 1175306 - 1175344 - 1175345 - 1175346 - 1175347 - 1175367 - 1175377 - 1175440 - 1175480 - 1175493 - 1175546 - 1175550 - 1175599 - 1175621 - 1175654 - 1175667 - 1175691 - 1175718 - 1175721 - 1175749 - 1175768 - 1175769 - 1175770 - 1175771 - 1175772 - 1175774 - 1175775 - 1175787 - 1175807 - 1175834 - 1175873 - 1175882 - 1175898 - 1175918 - 1175952 - 1175995 - 1175996 - 1175997 - 1175998 - 1175999 - 1176000 - 1176001 - 1176019 - 1176022 - 1176038 - 1176063 - 1176069 - 1176109 - 1176137 - 1176180 - 1176200 - 1176235 - 1176236 - 1176237 - 1176242 - 1176354 - 1176357 - 1176358 - 1176359 - 1176360 - 1176361 - 1176362 - 1176363 - 1176364 - 1176365 - 1176366 - 1176367 - 1176381 - 1176396 - 1176400 - 1176423 - 1176449 - 1176481 - 1176485 - 1176486 - 1176507 - 1176536 - 1176537 - 1176538 - 1176539 - 1176540 - 1176541 - 1176542 - 1176543 - 1176544 - 1176545 - 1176546 - 1176548 - 1176558 - 1176559 - 1176564 - 1176586 - 1176587 - 1176588 - 1176659 - 1176698 - 1176699 - 1176700 - 1176713 - 1176721 - 1176722 - 1176725 - 1176732 - 1176763 - 1176775 - 1176788 - 1176789 - 1176833 - 1176855 - 1176869 - 1176877 - 1176907 - 1176925 - 1176942 - 1176956 - 1176962 - 1176979 - 1176980 - 1176983 - 1176990 - 1177021 - 1177030 - 1177066 - 1177070 - 1177086 - 1177090 - 1177109 - 1177121 - 1177193 - 1177194 - 1177206 - 1177258 - 1177271 - 1177281 - 1177283 - 1177284 - 1177285 - 1177286 - 1177297 - 1177326 - 1177353 - 1177384 - 1177397 - 1177410 - 1177411 - 1177470 - 1177500 - 1177511 - 1177617 - 1177666 - 1177679 - 1177681 - 1177683 - 1177687 - 1177694 - 1177697 - 1177698 - 1177703 - 1177719 - 1177724 - 1177725 - 1177726 - 1177733 - 1177739 - 1177749 - 1177750 - 1177754 - 1177755 - 1177765 - 1177766 - 1177799 - 1177801 - 1177814 - 1177817 - 1177820 - 1177854 - 1177855 - 1177856 - 1177861 - 1178002 - 1178049 - 1178079 - 1178123 - 1178166 - 1178173 - 1178175 - 1178176 - 1178177 - 1178182 - 1178183 - 1178184 - 1178185 - 1178186 - 1178190 - 1178191 - 1178203 - 1178227 - 1178246 - 1178255 - 1178270 - 1178286 - 1178307 - 1178330 - 1178393 - 1178395 - 1178401 - 1178426 - 1178461 - 1178579 - 1178581 - 1178584 - 1178585 - 1178589 - 1178590 - 1178612 - 1178634 - 1178635 - 1178653 - 1178659 - 1178660 - 1178661 - 1178669 - 1178686 - 1178740 - 1178755 - 1178756 - 1178762 - 1178780 - 1178838 - 1178853 - 1178886 - 1179001 - 1179012 - 1179014 - 1179015 - 1179045 - 1179076 - 1179082 - 1179107 - 1179140 - 1179141 - 1179160 - 1179201 - 1179204 - 1179211 - 1179217 - 1179419 - 1179424 - 1179425 - 1179426 - 1179427 - 1179429 - 1179432 - 1179434 - 1179435 - 1179442 - 1179519 - 1179550 - 1179575 - 1179578 - 1179601 - 1179604 - 1179639 - 1179652 - 1179656 - 1179670 - 1179671 - 1179672 - 1179673 - 1179675 - 1179676 - 1179677 - 1179678 - 1179679 - 1179680 - 1179681 - 1179682 - 1179683 - 1179684 - 1179685 - 1179687 - 1179688 - 1179689 - 1179690 - 1179703 - 1179704 - 1179707 - 1179709 - 1179710 - 1179711 - 1179712 - 1179713 - 1179714 - 1179715 - 1179716 - 1179745 - 1179763 - 1179887 - 1179888 - 1179892 - 1179896 - 1179960 - 1179963 - 1180027 - 1180029 - 1180031 - 1180052 - 1180056 - 1180086 - 1180117 - 1180258 - 1180261 - 1180349 - 1180506 - 1180541 - 1180559 - 1180566 - 173030 - 744692 - 789311 - 954532 - 995541 i18n: note: "The feature impacted was not specifically about internationalization. \nThe bug could cause a denial of service.\n" answer: false question: | Was the feature impacted by this vulnerability about internationalization (i18n)? An internationalization feature is one that enables people from all over the world to use the system. This includes translations, locales, typography, unicode, or various other features. Answer should be true or false Write a note about how you came to the conclusions you did, regardless of what your answer was. vccs: - note: Discovered automatically by archeogit. commit: 6aa8b732ca01c3d7a54e93f4d701b8aabbe60fb7 - note: Discovered automatically by archeogit. commit: 70cd94e60c733e3afc18b0e6aab789c13b5571da fixes: - note: commit: - note: commit: - note: 'Manually confirmed ' commit: d80b64ff297e40c2b6f7d7abc1b3eba70d22a068 vouch: note: 'The git kernel has two reviewers listed on the commit page. ' answer: true question: | Was there any part of the fix that involved one person vouching for another's work? This can include: * signing off on a commit message * mentioning a discussion with a colleague checking the work * upvoting a solution on a pull request Answer must be true or false. Write a note about how you came to the conclusions you did, regardless of what your answer was. bounty: amt: url: announced: lessons: yagni: note: | This applies as the original developers assumed/forgot the freeing of memory. The developers could have assumed freeing memory was not needed. In order to remedy the issue the devlopers needed to implement a fix as it could have led to a denial of service attack. applies: true question: | Are there any common lessons we have learned from class that apply to this vulnerability? In other words, could this vulnerability serve as an example of one of those lessons? Leave "applies" blank or put false if you did not see that lesson (you do not need to put a reason). Put "true" if you feel the lesson applies and put a quick explanation of how it applies. Don't feel the need to claim that ALL of these apply, but it's pretty likely that one or two of them apply. If you think of another lesson we covered in class that applies here, feel free to give it a small name and add one in the same format as these. serial_killer: note: applies: false complex_inputs: note: applies: false distrust_input: note: applies: false least_privilege: note: applies: false native_wrappers: note: applies: false defense_in_depth: note: applies: false secure_by_default: note: | This applies as the original developers assumed/forgot the freeing of memory. In order to remedy the issue the devlopers needed to implement a fix at the root remembering to free the memory rather than fixing what happens if the memory is impacted. applies: true environment_variables: note: applies: false security_by_obscurity: note: applies: false frameworks_are_optional: note: applies: false reviews: [] sandbox: note: | The vulnerability does not sufficiently track and release allocated memory after it has been used. This issue is not in regard to sandboxing specifically. answer: false question: | Did this vulnerability violate a sandboxing feature that the system provides? A sandboxing feature is one that allows files, users, or other features limited access. Vulnerabilities that violate sandboxes are usually based on access control, checking privileges incorrectly, path traversal, and the like. Answer should be true or false Write a note about how you came to the conclusions you did, regardless of what your answer was. upvotes: CWE_note: 'Manually confirmed ' mistakes: answer: "The mistakes in this vulnerability could have been a lapse as a result of\nmere forgetfulness or the necessary functionality could've been left out\nin a planning error. Freeing memory is something any developer could \neasily leave out of their implementation.\nUpon evaluation the fix seems proper and maintainable as it is implemented\nat all levels of the conditional it exists in.\n" question: | In your opinion, after all of this research, what mistakes were made that led to this vulnerability? Coding mistakes? Design mistakes? Maintainability? Requirements? Miscommunications? There can, and usually are, many mistakes behind a vulnerability. Remember that mistakes can come in many forms: * slip: failing to complete a properly planned step due to inattention e.g. wrong key in the ignition e.g. using < instead of <= * lapse: failing to complete a properly planned step due to memory failure e.g. forgetting to put car in reverse before backing up e.g. forgetting to check null * planning error: error that occurs when the plan is inadequate e.g. getting stuck in traffic because you didn't consider the impact of the bridge closing e.g. calling the wrong method e.g. using a poor design These are grey areas, of course. But do your best to analyze the mistakes according to this framework. Look at the CWE entry for this vulnerability and examine the mitigations they have written there. Are they doing those? Does the fix look proper? Write a thoughtful entry here that people in the software engineering industry would find interesting. nickname: 'Memory Leak ' subsystem: name: arch note: 'Found in the Linux arch subsystem... arch/x86/kvm/svm/svm.c ' question: | What subsystems was the mistake in? These are WITHIN linux kernel Determining the subsystem is a subjective task. This is to help us group similar vulnerabilities, so choose a subsystem that other vulnerabilities would be in. Y Some areas to look for pertinent information: - Bug labels - Directory names - How developers refer to an area of the system in comments, commit messages, etc. Look at the path of the source code files code that were fixed to get directory names. Look at comments in the code. Look at the bug reports how the bug report was tagged. Example linux kernel subsystems are: * drivers * crypto * fs * net * lib Name should be: * all lowercase English letters * NOT a specific file * can have digits, and _-@/ Can be multiple subsystems involved, in which case you can make it an array e.g. name: ["subsystemA", "subsystemB"] # ok name: subsystemA # also ok discovered: answer: "Miaohe Lin discovered that the KVM implementation in the Linux kernel did \nnot properly deallocate memory on initialization for some processors. A\nlocal attacker could possibly use this to cause a denial of service. \nThis was not found by a Google employee.\nDate:\t2020-01-04\n" contest: false question: | How was this vulnerability discovered? Go to the bug report and read the conversation to find out how this was originally found. Answer in longform below in "answer", fill in the date in YYYY-MM-DD, and then determine if the vulnerability was found by a Google employee (you can tell from their email address). If it's clear that the vulenrability was discovered by a contest, fill in the name there. The automated, contest, and developer flags can be true, false, or nil. If there is no evidence as to how this vulnerability was found, then please explain where you looked. automated: false developer: true discussion: note: | Third parties dispute this issue because it's a one-time leak at the boot, the size is negligible, and it can't be triggered at will. question: | Was there any discussion surrounding this? A discussion can include debates, disputes, or polite talk about how to resolve uncertainty. Example include: * Is this out of our scope? * Is this a security? * How should we fix this? Just because you see multiple comments doesn't mean it's a discussion. For example: * "Fix line 10". "Ok" is not what we call a discussion * "Ping" (reminding people) Check the bugs reports, pull requests, and mailing lists archives. These answers should be boolean. discussed_as_security: true or false any_discussion: true or false Put any links to disagreements you found in the notes section, or any other comment you want to make. any_discussion: true discussed_as_security: true stacktrace: note: | I did not find any stacktraces. I checked kernel.org, ubuntu, nist.gov, and debian.org question: | Are there any stacktraces in the bug reports? Secondly, if there is a stacktrace, is the fix in the same file that the stacktrace points to? If there are no stacktraces, then both of these are false - but be sure to mention where you checked in the note. Answer must be true or false. Write a note about how you came to the conclusions you did, regardless of what your answer was. any_stacktraces: false stacktrace_with_fix: false description: | A one-time memory leak at the boot was discovered. The size is negligible, and it can't be triggered at will. They forgot to free the page held. unit_tested: fix: false code: false question: | Were automated unit tests involved in this vulnerability? Was the original code unit tested, or not unit tested? Did the fix involve improving the automated tests? For code: and fix: - your answer should be boolean. For the code_answer below, look not only at the fix but the surrounding code near the fix in related directories and determine if and was there were unit tests involved for this subsystem. For the fix_answer below, check if the fix for the vulnerability involves adding or improving an automated test to ensure this doesn't happen again. fix_answer: 'No automated testing was implemented. ' code_answer: "Only one file was modified in the commit. Upon searching the code there are\nno unit tests on the functionality. \n" reported_date: '2020-01-04' specification: note: | Violates CWE-401: Missing Release of Memory after Effective Lifetime. Found on the NVD site. answer: true instructions: | Is there mention of a violation of a specification? For example, the POSIX spec, an RFC spec, a network protocol spec, or some other requirements specification. Be sure to check the following artifacts for this: * bug reports * security advisories * commit message * mailing lists * anything else The answer field should be boolean. In answer_note, please explain why you come to that conclusion. announced_date: '2020-05-09' curation_level: 2 published_date: '2020-05-09' forgotten_check: note: | The commit modifies an existing if statement, implementing methods to free data. answer: true question: | Does the fix for the vulnerability involve adding a forgotten check? A "forgotten check" can mean many things. It often manifests as the fix inserting an entire if-statement or a conditional to an existing if-statement. Or a call to a method that checks something. Example of checks can include: * null pointer checks * check the current role, e.g. root * boundary checks for a number * consult file permissions * check a return value Answer must be true or false. Write a note about how you came to the conclusions you did, regardless of what your answer was. CWE_instructions: | Please go to http://cwe.mitre.org and find the most specific, appropriate CWE entry that describes your vulnerability. We recommend going to https://cwe.mitre.org/data/definitions/699.html for the Software Development view of the vulnerabilities. We also recommend the tool http://www.cwevis.org/viz to help see how the classifications work. If you have anything to note about why you classified it this way, write something in CWE_note. This field is optional. Just the number here is fine. No need for name or CWE prefix. If more than one apply here, then place them in an array like this CWE: ["123", "456"] # this is ok CWE: [123, 456] # also ok CWE: 123 # also ok autodiscoverable: note: | If it is possible for automated tools to monitor memory it is possible for this to be discovered by a fully automated tool. answer: true instructions: | Is it plausible that a fully automated tool could have discovered this? These are tools that require little knowledge of the domain, e.g. automatic static analysis, compiler warnings, fuzzers. Examples for true answers: SQL injection, XSS, buffer overflow In systemd, the actually use OZZ Fuzz. If there's a link to it, add it here. Examples for false: RFC violations, permissions issues, anything that requires the tool to be "aware" of the project's domain-specific requirements. The answer field should be boolean. In answer_note, please explain why you come to that conclusion. vcc_instructions: | The vulnerability-contributing commits. These are found by our tools by traversing the Git Blame history, where we determine which commit(s) introduced the functionality. Look up these VCC commits and verify that they are not simple refactorings, and that they are, in fact introducing the vulnerability into the system. Often, introducing the file or function is where the VCC is, but VCCs can be anything. Place any notes you would like to make in the notes field. bugs_instructions: | What bugs are involved in this vulnerability? Please list bug IDs to https://bugzilla.kernel.org/ Bug ID's can appear in several places: * Mentioned in commit messages * Mentioned in mailing list discussions * References from NVD entry * Various other places yaml_instructions: | ================= ===YAML Primer=== ================= This is a dictionary data structure, akin to JSON. Everything before a colon is a key, and the values here are usually strings For one-line strings, you can just use quotes after the colon For multi-line strings, as we do for our instructions, you put a | and then indent by two spaces For readability, we hard-wrap multi-line strings at 80 characters. This is not required, but appreciated. fixes_instructions: | Please put the commit hash in "commit" below. This must be a git commit hash from the systemd source repo, a 40-character hexademical string/ Place any notes you would like to make in the notes field. bounty_instructions: | If you came across any indications that a bounty was paid out for this vulnerability, fill it out here. Or correct it if the information already here was wrong. Otherwise, leave it blank. interesting_commits: commits: - note: | It was a really simple fix, 1 files changed, 6 insertions, 7 deletions. No other commits were made refrencing this method. commit: d80b64ff297e40c2b6f7d7abc1b3eba70d22a068 - note: commit: question: | Are there any interesting commits between your VCC(s) and fix(es)? Use this to specify any commits you think are notable in some way, and explain why in the note. Example interesting commits: * Mentioned as a problematic commit in the past e.g. "This fixes regression in commit xys" * A significant rewrite in the git history * Other commits that fixed a similar issue as this vulnerability * Anything else you find interesting. order_of_operations: note: 'The fix does not change order of operations, it implements new operations. ' answer: false question: | Does the fix for the vulnerability involve correcting an order of operations? This means the fix involves moving code around or changing the order of how things are done. Answer must be true or false. Write a note about how you came to the conclusions you did, regardless of what your answer was. curated_instructions: | If you are manually editing this file, then you are "curating" it. Set the version number that you were given in your instructions. This will enable additional editorial checks on this file to make sure you fill everything out properly. If you are a student, we cannot accept your work as finished unless curated is properly updated. upvotes_instructions: | For the first round, ignore this upvotes number. For the second round of reviewing, you will be giving a certain amount of upvotes to each vulnerability you see. Your peers will tell you how interesting they think this vulnerability is, and you'll add that to the upvotes score on your branch. nickname_instructions: | A catchy name for this vulnerability that would draw attention it. If the report mentions a nickname, use that. Must be under 30 characters. Optional. reported_instructions: | What date was the vulnerability reported to the security team? Look at the security bulletins and bug reports. It is not necessarily the same day that the CVE was created. Leave blank if no date is given. Please enter your date in YYYY-MM-DD format. announced_instructions: | Was there a date that this vulnerability was announced to the world? You can find this in changelogs, blogs, bug reports, or perhaps the CVE date. This is not the same as published date in the NVD - that is below. Please enter your date in YYYY-MM-DD format. published_instructions: | Is there a published fix or patch date for this vulnerability? Please enter your date in YYYY-MM-DD format. description_instructions: | You can get an initial description from the CVE entry on cve.mitre.org. These descriptions are a fine start, but they can be kind of jargony. Rewrite this description IN YOUR OWN WORDS. Make it interesting and easy to read to anyone with some programming experience. We can always pull up the NVD description later to get more technical. Try to still be specific in your description, but remove project-specific stuff. Remove references to versions, specific filenames, and other jargon that outsiders to this project would not understand. Technology like "regular expressions" is fine, and security phrases like "invalid write" are fine to keep too. Your target audience is people just like you before you took any course in security |
See a mistake? Is something missing from our story? We welcome contributions! All of our work is open-source and version-controlled on GitHub. You can curate using our Curation Wizard.
Hover over an event to see its title.
Click on the event to learn more.
Filter by event type with the buttons below.
