baaa35ad706419ae5aacc11d2bece5bd8b73ee42 | Vulnerability History Project

The Vulnerability History Project

coccinelle: make use of SYNTHETIC_ERRNO

      Ideally, coccinelle would strip unnecessary braces too. But I do not see any
option in coccinelle for this, so instead, I edited the patch text using
search&replace to remove the braces. Unfortunately this is not fully automatic,
in particular it didn't deal well with if-else-if-else blocks and ifdefs, so
there is an increased likelikehood be some bugs in such spots.

I also removed part of the patch that coccinelle generated for udev, where we
returns -1 for failure. This should be fixed independently.

by Chelsea the Jackal 2018-11-20 22:40:44 UTC

commit baaa35ad706419ae5aacc11d2bece5bd8b73ee42

systemd VCC CVE-2018-16865

coccinelle/synthetic-errno.cocci

-35

src/ac-power/ac-power.c

+4 -4

src/activate/activate.c

+22 -17

src/analyze/analyze.c

+24 -19

src/ask-password/ask-password.c

+4 -4

src/basic/cgroup-util.c

+5 -4

src/basic/fileio.c

+4 -6

src/basic/log.h

+2 -2

src/basic/process-util.c

+2 -1

src/basic/rm-rf.c

+8 -8

src/binfmt/binfmt.c

+8 -6

src/boot/bless-boot.c

+28 -26

src/boot/bootctl.c

+21 -20

src/busctl/busctl-introspect.c

+164 -133

src/busctl/busctl.c

+20 -17

src/cgls/cgls.c

+4 -3

src/cgtop/cgtop.c

+16 -15

src/core/dbus.c

+4 -3

+4 -4

src/core/machine-id-setup.c

+4 -4

src/core/main.c

+34 -27

src/core/namespace.c

+20 -18

src/core/path.c

+4 -3

src/core/shutdown.c

+4 -3

src/core/swap.c

+4 -4

src/coredump/coredump.c

+21 -19

src/coredump/coredumpctl.c

+16 -12

src/cryptsetup/cryptsetup-generator.c

+8 -7

src/cryptsetup/cryptsetup.c

+14 -12

src/debug-generator/debug-generator.c

+4 -3

src/delta/delta.c

+10 -8

src/detect-virt/detect-virt.c

+4 -4

src/dissect/dissect.c

+12 -10

src/escape/escape.c

+36 -27

src/firstboot/firstboot.c

+24 -18

src/fstab-generator/fstab-generator.c

+4 -3

src/hibernate-resume/hibernate-resume-generator.c

+4 -3

src/import/curl-util.c

+8 -6

src/import/export.c

+4 -3

src/import/pull-common.c

+8 -6

src/import/pull-job.c

+28 -18

src/import/pull.c

+4 -3

src/initctl/initctl.c

+4 -3

src/journal-remote/journal-gatewayd.c

+26 -20

src/journal-remote/journal-remote-main.c

+102 -76

src/journal-remote/journal-upload-journal.c

+4 -3

src/journal-remote/journal-upload.c

+76 -63

src/journal-remote/microhttpd-util.c

+6 -4

src/journal/cat.c

+4 -3

src/journal/catalog.c

+20 -21

src/journal/journal-file.c

+175 -147

src/journal/journalctl.c

+22 -18

src/journal/journald-server.c

+20 -16

src/journal/journald-stream.c

+4 -4

src/journal/sd-journal.c

+23 -23

src/libsystemd-network/dhcp-packet.c

+45 -37

src/libsystemd/sd-bus/bus-message.c

+5 -7

src/libsystemd/sd-device/sd-device.c

+8 -8

src/libsystemd/sd-netlink/sd-netlink.c

+8 -8

src/locale/localectl.c

+4 -3

src/login/inhibit.c

+4 -3

src/login/loginctl.c

+16 -13

src/login/logind-button.c

+4 -4

src/login/logind-dbus.c

+4 -4

src/login/logind-session-device.c

+4 -3

src/login/logind-session.c

+8 -8

src/login/logind.c

+4 -4

src/login/user-runtime-dir.c

+8 -6

src/machine-id-setup/machine-id-setup-main.c

+4 -3

src/machine/machinectl.c

+35 -27

src/mount/mount-tool.c

+55 -44

src/notify/notify.c

+8 -6

src/nspawn/nspawn-cgroup.c

+2 -2

src/nspawn/nspawn-mount.c

+9 -9

src/nspawn/nspawn-setuid.c

+40 -30

src/nspawn/nspawn.c

+214 -163

src/partition/growfs.c

+5 -4

src/partition/makefs.c

+4 -3

src/path/path.c

+2 -2

src/portable/portablectl.c

+16 -12

src/quotacheck/quotacheck.c

+4 -3

src/random-seed/random-seed.c

+12 -9

src/remount-fs/remount-fs.c

+4 -3

src/resolve/resolvconf-compat.c

+20 -17

src/resolve/resolvectl.c

+81 -65

src/resolve/resolved-dns-dnssec.c

+4 -4

src/resolve/resolved-dns-packet.c

+4 -4

src/resolve/resolved-dns-transaction.c

+9 -8

src/resolve/resolved-dnssd.c

+4 -4

src/resolve/resolved-dnstls-gnutls.c

+4 -6

src/resolve/resolved-dnstls-openssl.c

+2 -3

src/resolve/resolved-etc-hosts.c

+8 -8

src/resolve/resolved-manager.c

+12 -9

src/rfkill/rfkill.c

+4 -3

+56 -43

src/shared/bootspec.c

+8 -7

src/shared/bus-unit-util.c

+46 -42

src/shared/bus-util.c

+5 -3

src/shared/dissect-image.c

+4 -3

src/shared/dropin.c

+4 -4

src/shared/efivars.c

+4 -3

src/shared/generator.c

+12 -12

src/shared/install.c

+8 -7

src/shared/journal-importer.c

+17 -16

src/shared/logs-show.c

+28 -21

src/shared/seccomp-util.c

+4 -4

src/shared/serialize.c

+4 -4

src/shared/sleep-config.c

+2 -2

src/shared/verbs.c

+8 -6

src/sleep/sleep.c

+21 -17

src/socket-proxy/socket-proxyd.c

+16 -12

src/stdio-bridge/stdio-bridge.c

+2 -2

src/sysctl/sysctl.c

+4 -3

src/systemctl/systemctl.c

+99 -84

src/sysusers/sysusers.c

+16 -13

src/timedate/timedatectl.c

+8 -6

src/timesync/timesyncd-manager.c

+4 -3

src/tmpfiles/tmpfiles.c

+52 -47

src/tty-ask-password-agent/tty-ask-password-agent.c

+20 -15

src/udev/mtd_probe/probe_smartmedia.c

+16 -12

src/udev/udev-builtin-kmod.c

+4 -3

src/udev/udev-event.c

+4 -3

src/udev/udev-rules.c

+4 -4

src/udev/udevadm-hwdb.c

+4 -3

src/udev/udevadm-settle.c

+2 -3

src/udev/udevadm-test-builtin.c

+8 -6

src/udev/udevadm-test.c

+8 -6

src/user-sessions/user-sessions.c

+6 -4

src/volatile-root/volatile-root.c

+20 -15

expand_less