CVE-2016-1707

CVE: CVE-2016-1707
CWE:
- 20
bugs:
- 622183
repo: 
vccs:
- note: 
  commit: f7cf3d0cf5502338d39aa04b4c41cbde76b96950
- note: 
  commit: 72db63d4ef6bae79ac01687b6cc4d6db0d657c1a
fixes:
- note: Actually fixed in 5967e80f, just cherry picked from c2d2b0f2f74dad0bdef196cf1657f0d584cbe3a7
  commit: 5967e8c0fe0b1e11cc09d6c88304ec504e909fd5
- note: Actually fixed in 5967e80f, just cherry picked from c2d2b0f2f74dad0bdef196cf1657f0d584cbe3a7
  commit: c2d2b0f2f74dad0bdef196cf1657f0d584cbe3a7
bounty:
  date: '2016-07-20 14:48:00.000000000 -04:00'
  amount: 3000.0
  references:
  - http://chromereleases.googleblog.com/2016/07/stable-channel-update.html
lessons:
  yagni:
    note: 
    applies: 
  question: |
    Are there any common lessons we have learned from class that apply to this
    vulnerability? In other words, could this vulnerability serve as an example
    of one of those lessons?

    Leave "applies" blank or put false if you did not see that lesson (you do
    not need to put a reason). Put "true" if you feel the lesson applies and put
    a quick explanation of how it applies.

    Don't feel the need to claim that ALL of these apply, but it's pretty likely
    that one or two of them apply.

    If you think of another lesson we covered in class that applies here, feel
    free to give it a small name and add one in the same format as these.
  serial_killer:
    note: 
    applies: 
  complex_inputs:
    note: 
    applies: 
  distrust_input:
    note: I believe this applies somewhat. While this is not necessarily a form input,
      one must also distrust the urls that are being inputted by the user.
    applies: true
  least_privilege:
    note: 
    applies: 
  native_wrappers:
    note: 
    applies: 
  defense_in_depth:
    note: 
    applies: 
  secure_by_default:
    note: 
    applies: 
  environment_variables:
    note: 
    applies: 
  security_by_obscurity:
    note: 
    applies: 
  frameworks_are_optional:
    note: 
    applies: 
reviews:
- 2096023002
- 2086333003
upvotes: 9
mistakes:
  answer: |-
    I believe this was primarily a logic error that did not expect the url to be invalid. The first time the iOS web controller was included into Chromium, it was only making sure that the URL was as expected, but it did not really do anything if the URL was not as expected.
    Furthermore, this is an interesting case of a spoofing attack. This is an Improper Input Validation vulnerability instead of what is commonly a URL Redirect bug because the exploit works by inputing an invalid URL to force an error on Chrome.
  question: |
    In your opinion, after all of this research, what mistakes were made that
    led to this vulnerability? Coding mistakes? Design mistakes?
    Maintainability? Requirements? Miscommunications?

    Look at the CWE entry for this vulnerability and examine the mitigations
    they have written there. Are they doing those? Does the fix look proper?

    Use those questions to inspire your answer. Don't feel obligated to answer
    every one. Write a thoughtful entry here that those ing the software
    engineering industry would find interesting.
announced: '2016-07-23 15:59:02.543000000 -04:00'
subsystem:
  name: ios/web_controller
  answer: The internal logic for the iOS web controller needed to also check for whether
    or not the URL was actually valid
  question: |
    What subsystems was the mistake in?

    Look at the path of the source code files code that were fixed to get
    directory names. Look at comments in the code. Look at the bug reports how
    the bug report was tagged. Examples: "clipboard", "gpu", "ssl", "speech", "renderer"
discovered:
  date: '2016-06-22'
  answer: Originally discovered by researcher xisigr of Tencent's Xuanwu Lab and submitted
    through the bug disclosure portal. S/he does not explain how the discovery happened.
  google: false
  contest: 
  question: |
    How was this vulnerability discovered?

    Go to the bug report and read the conversation to find out how this was
    originally found. Answer in longform below in "answer", fill in the date in
    YYYY-MM-DD, and then determine if the vulnerability was found by a Google
    employee (you can tell from their email address). If it's clear that the
    vulenrability was discovered by a contest, fill in the name there.

    The "automated" flag can be true, false, or nil.
    The "google" flag can be true, false, or nil.

    If there is no evidence as to how this vulnerability was found, then you may
    leave the entries blank except for "answer". Write down where you looked in "answer".
  automated: false
description: On iPhones, remote attackers can make malicious web sites look safe by
  masking the URL with a trusted website like https://google.com.
unit_tested:
  fix: true
  code: true
  answer: Yes, there were automated tests
  question: |
    Were automated unit tests involved in this vulnerability?
    Was the original code unit tested, or not unit tested? Did the fix involve
    improving the automated tests?

    For the "code" answer below, look not only at the fix but the surrounding
    code near the fix and determine if and was there were unit tests involved
    for this module.

    For the "fix" answer below, check if the fix for the vulnerability involves
    adding or improving an automated test to ensure this doesn't happen again.
major_events:
  answer: The error started in the very first ios push. See the first vcc.
  events:
  - date: 
    name: 
  - date: 
    name: 
  question: |
    Please record any major events you found in the history of this
    vulnerability. Was the code rewritten at some point? Was a nearby subsystem
    changed? Did the team change?

    The event doesn't need to be directly related to this vulnerability, rather,
    we want to capture what the development team was dealing with at the time.
curation_level: 1
CWE_instructions: |
  Please go to cwe.mitre.org and find the most specific, appropriate CWE entry
  that describes your vulnerability. (Tip: this may not be a good one to start
  with - spend time understanding this vulnerability before making your choice!)
bounty_instructions: |
  If you came across any indications that a bounty was paid out for this
  vulnerability, fill it out here. Or correct it if the information already here
  was wrong. Otherwise, leave it blank.
interesting_commits:
  answer: 
  commits:
  - note: This was interesting because this one the second vcc commit that was almost
      two months after the first vcc commit. One can extrapolate that the programmer
      used the first bit of committed code as a reference for his part, thereby creating
      two errors that needed to be fixed later.
    commit: 72db63d4ef6bae79ac01687b6cc4d6db0d657c1a
  - note: 
    commit: 
  question: |
    Are there any interesting commits between your VCC(s) and fix(es)?

    Write a brief (under 100 words) description of why you think this commit was
    interesting in light of the lessons learned from this vulnerability. Any
    emerging themes?

    If there are no interesting commits, demonstrate that you completed this section by explaining what happened between the VCCs and the fix.
curated_instructions: |
  If you are manually editing this file, then you are "curating" it. Set the
  entry below to "true" as soon as you start. This will enable additional
  integrity checks on this file to make sure you fill everything out properly.
  If you are a student, we cannot accept your work as finished unless curated is
  set to true.
upvotes_instructions: |
  For the first round, ignore this upvotes number.

  For the second round of reviewing, you will be giving a certain amount of
  upvotes to each vulnerability you see. Your peers will tell you how
  interesting they think this vulnerability is, and you'll add that to the
  upvotes score on your branch.
announced_instructions: |
  Was there a date that this vulnerability was announced to the world? You can
  find this in changelogs, blogs, bug reports, or perhaps the CVE date. A good
  source for this is Chrome's Stable Release Channel
  (https://chromereleases.googleblog.com/).
  Please enter your date in YYYY-MM-DD format.
fixes_vcc_instructions: |
  Please put the commit hash in "commit" below (see my example in
  CVE-2011-3092.yml). Fixes and VCCs follow the same format.
description_instructions: |
  You can get an initial description from the CVE entry on cve.mitre.org. These
  descriptions are a fine start, but they can be kind of jargony.

  Rewrite this description in your own words. Make it interesting and easy to
  read to anyone with some programming experience. We can always pull up the NVD
  description later to get more technical.

  Try to still be specific in your description, but remove Chromium-specific
  stuff. Remove references to versions, specific filenames, and other jargon
  that outsiders to Chromium would not understand. Technology like "regular
  expressions" is fine, and security phrases like "invalid write" are fine to
  keep too.